Project

General

Profile

Actions

Bug #434

closed

Some functions don't seem's to work in view.cpp

Added by David Gayou over 13 years ago. Updated over 13 years ago.

Status:
Rejected
Priority:
Normal
Assignee:
-
Category:
libyzis
Target version:
-
Start date:
11/14/2008
Due date:
% Done:

0%

Estimated time:

Description

functions : gotoLineColumn, gotoLineColumnAndStick seem's to have no effects on the cursor.
That's probably the functions gotoViewCursor() or viewCursorFromLineColumn(line, column) that are not working.

I join a brief patch with an uncomplete function but that show how gotoLineColumnAndStick don't work as expected (or at least i think).


Files

ViewFunctionNotWorking.patch (2.3 KB) ViewFunctionNotWorking.patch patch with a brief function gotoColumn where the function called don't work David Gayou, 11/14/2008 03:21 PM
Actions #1

Updated by Loïc P. over 13 years ago

  • Status changed from New to Rejected

What you are doing is wrong ;)
Motions should not directly move the cursor (like gotoXXX are doing), but only compute the destination buffer position.
Just look at YModeCommand::moveLeft.

In your patch you are returning the buffer as it was before moving the cursor, so there is 2 errors :p

returning args.view->viewCursorFromLineColumn(lineToGo, colToGo) will be sufficient.

Actions

Also available in: Atom PDF