Project

General

Profile

Actions

Feature #498

open

"persistent" marks. ie. marks that move in column when you delete prior to the mark

Added by Reza Jelveh over 13 years ago. Updated over 13 years ago.

Status:
New
Priority:
Normal
Assignee:
Category:
-
Target version:
Start date:
01/10/2009
Due date:
% Done:

70%

Estimated time:

Description

This is the same issue that prevents vim from having a proper snippet plugin.
emacs textmate and elvis(or vile i don't remember) have this behavior.

steps to reproduce:
1. write some text
test test test test test
^
2. put a mark
3. delete a word in front of the mark

the mark should now move
test test test test
^

what actually happens is that the mark stays at the same place
test test test test
^


Files

persistentmarks.diff (7.84 KB) persistentmarks.diff Reza Jelveh, 01/24/2009 07:05 PM
Actions #1

Updated by Reza Jelveh over 13 years ago

sorry it was actually supposed to look like this:

1. write some text

test test test test test
          ^

2. put a mark
3. delete a word in front of the mark

the mark should now move

test test test test
     ^

what actually happens is that the mark stays at the same place

test test test test
          ^

Actions #2

Updated by Reza Jelveh over 13 years ago

  • File percentcommandfix.diff added
  • Assignee set to Loïc P.
  • Target version set to 1.0-beta1
  • % Done changed from 0 to 70

Here's my first attempt at it.
TODO:
- insertchar and deletechar shouldn't really be the ones calling adjustmarks, i guess it should go in delete/insertRegion
- maybe split the code out of yline
- some more exception handling maybe? im not sure if i really clean up all marks properly
- add size to it, maybe?

I'd like to hear some comments on it though...

Actions #3

Updated by Reza Jelveh over 13 years ago

sorry, wrong patch added. can someone delete the other one?

Actions #4

Updated by Thomas Capricelli over 13 years ago

  • File deleted (percentcommandfix.diff)
Actions

Also available in: Atom PDF